Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Related to #2849: Allows ValuesFiles to be templatable #3111

Merged
merged 2 commits into from
Jan 15, 2020

Conversation

Markcial
Copy link
Contributor

@Markcial Markcial commented Oct 22, 2019

Relates to #2849.

Should merge before : none

Should merge after : none

Description

User facing changes

Behaviour change on helm, allows ValuesFiles to be used as templates

Before

n/a

After

n/a

Next PRs.

More fields to be templatable, up to design decision from the skaffold team

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Mentions any output changes.
  • Adds documentation as needed: user docs, YAML reference, CLI reference.
  • Adds integration tests if needed.

Reviewer Notes

  • The code flow looks good.
  • Unit test added.
  • User facing changes look good.

Release Notes

Update on helm:
* ValuesFiles can be rendered with environment and build variables

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@Markcial
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@codecov
Copy link

codecov bot commented Oct 22, 2019

Codecov Report

Merging #3111 into master will increase coverage by 0.04%.
The diff coverage is 61.53%.

Impacted Files Coverage Δ
pkg/skaffold/deploy/helm.go 78.64% <61.53%> (-0.11%) ⬇️
pkg/skaffold/util/tar.go 57.47% <0%> (+4.59%) ⬆️

@dgageot dgageot added the kokoro:run runs the kokoro jobs on a PR label Oct 31, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Oct 31, 2019
Copy link
Contributor

@dgageot dgageot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Markcial for the PR! Any way we could remove the duplication with previous block?

@Markcial
Copy link
Contributor Author

Markcial commented Jan 7, 2020

@dgageot maybe i can use a inline function to simplify that behaviour and make it useful for any field that would became templatable in the future.

Sounds good for you?

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Jan 7, 2020
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Jan 8, 2020
@Markcial Markcial requested a review from dgageot January 8, 2020 09:06
@nkubala nkubala added the kokoro:run runs the kokoro jobs on a PR label Jan 8, 2020
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Jan 8, 2020
@dgageot dgageot merged commit cd9c19b into GoogleContainerTools:master Jan 15, 2020
dgageot pushed a commit to dgageot/skaffold that referenced this pull request Jan 15, 2020
…table (GoogleContainerTools#3111)

* Related to GoogleContainerTools#2849: Allows ValuesFiles to be templatable

* Uses function to simplify calls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants